Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes #102

Merged
merged 7 commits into from
Aug 19, 2023
Merged

Various fixes #102

merged 7 commits into from
Aug 19, 2023

Conversation

evensolberg
Copy link
Contributor

@evensolberg evensolberg commented Aug 13, 2023 •
edited
Loading

  • Cleaned up the code a little by running Clippy in pedantic mode
    • Made the code a little more Rust-like by implmenting the Default trait for some structs.
  • Added --lon as an alias for --lng
  • Allow negative numbers for latitude and longitude, meaning we can go to the southern and western hemispheres.

@evensolberg
Create justfile
8364a2b
@evensolberg
Various fixes
58d595b 
- Cleaned up lints
- Added `--lon` alias for `--lng`
- Allow negative numbers (!)
@evensolberg
Delete justfile
2b7c681
@evensolberg
Update Cargo.lock
88706f7
@evensolberg
Version bump
c24eb79
ringsaturn
ringsaturn requested changes Aug 14, 2023
View reviewed changes
Copy link
Owner

@ringsaturn ringsaturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Require some changes

src/gen/pb.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
ringsaturn
ringsaturn approved these changes Aug 19, 2023
View reviewed changes
Copy link
Owner

@ringsaturn ringsaturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ringsaturn ringsaturn merged commit 05157f3 into ringsaturn:main Aug 19, 2023
1 check passed
@evensolberg evensolberg deleted the Lint-Fix branch August 19, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ringsaturn ringsaturn ringsaturn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evensolberg @ringsaturn